search

morse-simulator / morse

The Modular OpenRobots Simulation Engine
http://morse-simulator.github.io/
Other
351 stars 155 forks source link

Change logger level of ROS middleware to INFO (or default) #771

Closed CodeFinder2 closed 6 years ago

CodeFinder2 commented 6 years ago

Hi,

I would suggest to change the logger level (see code here) to rospy.INFO or simply omit that parameter to use the ROS default. This causes various outputs during the startup of MORSE which renders the logging somehow unusable (too many lines). IMHO; rospy.DEBUG should only be used during development (of MORSE).

Any comments on this?

Thanks!

dgerod commented 6 years ago

It's OK for me, I think that best solution is to omit the parameter so we will do what is default for ROS. I have just checked how to manage vervosity in ROS, and it match what you are proposing.

Could you check MORSE code in which ROS logger is used and modify it according to your proposal? It should be only in middleware and middlewaer/ros directories. And after doing it you create a pull request. Thanks.

CodeFinder2 commented 6 years ago

Thanks for your reply, done (see https://github.com/morse-simulator/morse/pull/775 ).