search

moscajs / aedes-persistence

In-memory implementation of an Aedes persistence, with abstract tests
MIT License
13 stars 22 forks source link

fix: handle persisting the dup flag #79

Open robertsLando opened 3 years ago

robertsLando commented 3 years ago

Reference to https://github.com/moscajs/aedes/pull/603

gnought commented 2 years ago

LGTM

mcollina commented 2 years ago

The original design of Aedes had this not persisted for a reason.

robertsLando commented 2 years ago

@mcollina Could you explain? This is actually blocking https://github.com/moscajs/aedes/pull/603. Any suggestions?

mcollina commented 2 years ago

I can't recall and don't have much room m time to investigate :/. Go ahead and land.

robertsLando commented 2 years ago

@tomekt-bolt are you still interested in this? COuld you write a unit test that covers it?