Fix unintended relation to users when a model uses HasPermissions trait

brandonlim-hs commented 5 years ago

Description

Moved users method from HasPermissions trait to Role model. The list of users related to Role or Permission are still accessible from the respective models. For example, $role->users and $permission->users

Motivation and context

Models that use HasPermissions trait should not unintentionally be related to User model. fixes #94

How has this been tested?

Added additional tests to assert that a model that uses HasRoles or HasPermissions trait does not have users method

/** @test */
public function a_model_that_uses_hasPermissions_trait_should_not_have_users_method()
{
    $this->assertFalse(method_exists($this->testUser, 'users'));
}

/** @test */
public function a_model_that_uses_hasRoles_trait_should_not_have_users_method()
{
    $this->assertFalse(method_exists($this->testUser, 'users'));
}

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

[x] I have read the CONTRIBUTING document.
[x] My pull request addresses exactly one patch/feature.
[x] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[x] I have added tests to cover my changes.
[x] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling cc213541343d9050c10487d66edad4409e2ad4d4 on brandonlim-hs:bugfix-unintended-users-relation into 954633b7b349c3817e97864844c75e37277a2264 on mostafamaklad:master.

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling cc213541343d9050c10487d66edad4409e2ad4d4 on brandonlim-hs:bugfix-unintended-users-relation into 954633b7b349c3817e97864844c75e37277a2264 on mostafamaklad:master.

mostafamaklad / laravel-permission-mongodb