Update in select query no search the correct value of the primary key. (post diff files)

motaz / turbobird

FireBird admin tool

http://code.sd/turbobird

57 stars 28 forks source link

Update in select query no search the correct value of the primary key. (post diff files) #24

Closed clauslack closed 10 years ago

clauslack commented 10 years ago

Update in select query no search the correct value of the primary key. This can update an wrong record.
Add two functions for convert Date and DateTime to firebird date format (http://www.firebirdfaq.org/faq137/) I test with lazarus 1.2.2 fpc 2.6.4, source motaz-turbobird-9cec71b.zip (26/05/2014) under Windows Xp. Firebird Server 2.1.6.

Diff for querywindow.pas http://linkode.org/XHTluH6ytXJpBBd5OVUhx3

Diff for turbocommon.pas http://linkode.org/vl9mp4piYW1Z5yXL67Cya2

Regards

reiniero commented 10 years ago

Hi clauslack, those look like good additions, but actually I'm rewriting the querywindow grid handling to use standard SQLDB auto-generated insertsql/updatesql/deletesql...

I'll let you know if that works ok - otherwise I'll surely try and implement your patches. Thanks.

reiniero commented 10 years ago

Oh, if you want to, I'd be happy to talk about changes/fixes e.g. on the Lazarus forum (user BigChimp). Thanks a lot for your contributions.

reiniero commented 10 years ago

Clauslack, in 6514ac17f32b59543ee4678b20e5404ef5fcfb63 I used standard sqldb auto-generated insertsql/updatesql/deletesql. Could you perhaps test with this version and give your comments? Thanks.

clauslack commented 10 years ago

Not problem, I will test that in my job.

Regards.

clauslack commented 10 years ago

The edit Select Query seems to work ok. Regards