Closed zanetworker closed 10 years ago
This closes #33
thanks for the quick commit. Two comments:
remove_dictionary_element
.gen-certs.sh~
...@motine Yes tom, I could use the pop method, but I did not want anything to be returned (pop returns the value of the key poped), therefore I created a remove method.
cool stuff. you can always ignore the return value... Two more things:
fetch_fields
, what if we rename this to pop_fields
, so we remove the fields in there. Now it seems tedious to first fetch and then pop.options_validity_check
was good for testing, but I would recommend removing this now. Reason: I think the Delegate should rely on the fact that the Handler correctly created the fields and options parameter. The Delegate should not have to check these parameter again.Keep up the good work. Even if it seems tedious what we are doing here. It is worth it!
Totally agree, at least now it make sense to use pop :)