motine / Ohouse

Ohouse
Other
3 stars 2 forks source link

Fix redundant parameters without removing fields #39

Closed zanetworker closed 10 years ago

zanetworker commented 10 years ago
zanetworker commented 10 years ago

This closes #33

motine commented 10 years ago

thanks for the quick commit. Two comments:

zanetworker commented 10 years ago

@motine Yes tom, I could use the pop method, but I did not want anything to be returned (pop returns the value of the key poped), therefore I created a remove method.

motine commented 10 years ago

cool stuff. you can always ignore the return value... Two more things:

Keep up the good work. Even if it seems tedious what we are doing here. It is worth it!

zanetworker commented 10 years ago

Totally agree, at least now it make sense to use pop :)