search

motine / Ohouse

Ohouse
Other
3 stars 2 forks source link

Validating slice names #42

Closed zanetworker closed 10 years ago

zanetworker commented 10 years ago

After writing the regular expressions for validating slice_names, I found by testing that there is a method that already checks the validity of slice names in slice tool. Therefore, after adding the test, this pull request should close #41

broadbent commented 10 years ago

Well spotted @zanetworker. I've just checked the regex though, and there is a bug in it. After some clarification from the guys at the GPO, it appears that underscore is not a legal character:

Per the AM API, hyphen is legal, underscore is not.

Could you change the regex to match this, and form another pull request? Only one character needs removing.