search

motine / Ohouse

Ohouse
Other
3 stars 2 forks source link

Exceptions Decoupling #45

Closed zanetworker closed 10 years ago

zanetworker commented 10 years ago

This pull requests should close #17

motine commented 10 years ago

Hi, good work. Can you please keep pull-requests tidy in the future? Currently, all 3 requests contain the same commits. This is not nice. Please always branch of the fork and start from there.

zanetworker commented 10 years ago

Currently, I have 3 branches. Usually, I do a fork per pull request, but because my pull request is pending I branched from my "Commited fork".

motine commented 10 years ago

Also, i am not sure if the mongodatabase should know anything about slice urns. Can we add this knowledge/function somewhere else? Ask yourself: which entity should be aware of this pre-processing? (...now I am back on vacation...)

zanetworker commented 10 years ago

Okay :D

motine commented 10 years ago

Please make it so that different pull requests have different contents.

motine commented 10 years ago

And, thanks for the good work! The rest looks good. Matt and i will check it start of next week.

zanetworker commented 10 years ago

Okay, I will try to make a new fork. I am not sure if I can have multiple forks of the same project at the same time. This way I can branch from a clean fork. And thanks, I hope you are having good time :)

motine commented 10 years ago

a branch is enough. keep the master branch as is. then always branch from there. if the pull request was accepted, then you can rebase your master and whatever has not been submitted. I think you do not need to go through the trouble for these requests, because that means wasted work. it is more a tipp for the future.

The other fix would be great though.

zanetworker commented 10 years ago

On it, I will commit it to the second pull requests (several urns). Thanks for your comments anyway :)