search

motiv-labs / janus

An API Gateway written in Go
https://hellofresh.gitbooks.io/janus
MIT License
2.78k stars 318 forks source link

PT-2147 Fixed configuration listener that made API stuck #366

Closed vgarvardt closed 5 years ago

vgarvardt commented 5 years ago

What does this PR do?

Now server is listening to the configuration changes in any case, even if provider does not implement Listener, so we can use "file" storage as memory - all the persistent definitions are loaded on startup, but then API allows to manipulate proxies in memory. Otherwise api calls just stuck because channel is busy.

codecov[bot] commented 5 years ago

Codecov Report

Merging #366 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   40.34%   40.34%           
=======================================
  Files          74       74           
  Lines        2553     2553           
=======================================
  Hits         1030     1030           
  Misses       1464     1464           
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ffb8c8...3a8af07. Read the comment docs.