Url parameters for whole target

motiv-labs / janus

An API Gateway written in Go

https://hellofresh.gitbooks.io/janus

MIT License

2.78k stars 318 forks source link

Url parameters for whole target #394

Closed Serjick closed 5 years ago

Serjick commented 5 years ago

What does this PR do?

A few sentences describing the overall goals of the pull request's commits.

Allow to use url parameteres not only in path but for whole target. E.g.

...
      "listen_path":"/{service}/*",
      "upstreams":{
         "balancing":"weight",
         "targets":[
            {
               "target":"http://{service}:8080",
               "weight":100
            }
         ]
      },
...

vgarvardt commented 5 years ago

Hello @Serjick. Thank you for your contribution. Implementation looks good but could you please add some tests for it? Would be great to have BDD (godog/features) tests here.

Serjick commented 5 years ago

Hello @vgarvardt! Such simple test is enough?

vgarvardt commented 5 years ago

👍

RTodorov commented 5 years ago