Add Oulipo::Validators::StatusValidator

mouse-reeve / mastodon

GNU Social cross-functional microblogging: an oulipo fork

https://oulipo.social

GNU Affero General Public License v3.0

11 stars 10 forks source link

Add Oulipo::Validators::StatusValidator #23

Closed ecmendenhall closed 7 years ago

ecmendenhall commented 7 years ago

Fix for #10

Yank FIFTH_GLYPH_R*G*X up from Oulipo::Formatt*r
Do Status validation via Activ*R*cord validator
Add Oulipo i18n strings
Add Activ*R*cord i18n strings

Q for you, @mouse-reeve: I don't know that I grasp local vs nonlocal toots...do toots from "Global activity" also go in our DB as local toots? If so, this might blow up, as global toots should allow invalid glyphs, but local toots should not. If not, this is OK.

ecmendenhall commented 7 years ago

(It should only apply validation to local toots, thanks to this status.local? bit)

ecmendenhall commented 7 years ago

Bah, a TODO: this should also apply validation to spoil*r_t*xt, a distinct column on Status.

ecmendenhall commented 7 years ago

OK, now it's good.

mouse-reeve commented 7 years ago

Looks like there's a merge conflict, but I'm happy to merge this in otherwise

ecmendenhall commented 7 years ago

Thanks, can't look right now, but I'll patch it up tonight!

ecmendenhall commented 7 years ago

Good now! I'm thinking of a way to fix automatic trials from Mastodon's main branch: put our invalid glyphs in config, and modify that in RAILS_*NV=test. I'll do a distinct PR for it.

ecmendenhall commented 7 years ago

I am not good at this without that magic box.