search

mouse0270 / module-credits

Lists the authors of projects on the Manage Modules Window. If a url is provided in the module.json file, it will make the version tag link to the module url.
MIT License
7 stars 7 forks source link

[BUG] Locking a setting locks all settings #53

Closed MrVauxs closed 2 years ago

MrVauxs commented 2 years ago

As the title implies. See the video.

Foundry: V10.285 System: Pathfinder 2e v4.0.6 Replicated with no other modules enabled. No console messages appeared when locking and unlocking.

https://user-images.githubusercontent.com/32039708/191256591-362e3e57-4786-43ad-a26b-850161368f40.mp4

mouse0270 commented 2 years ago

Found the issue, it appears the way I was getting the settings key doesn't work all of the sudden... I have a patch, but I am also working on updating a locked setting so that it will auto set the players values when they login. So I am going to make both of those changes and then push the fix out.

mouse0270 commented 2 years ago

If you wouldn't mind testing out Version 2.0.4 and confirming this fixes the issue for me, I'd really appreciate it.

manifest.json: https://github.com/mouse0270/module-credits/releases/download/2.0.4/module.json

MrVauxs commented 2 years ago

Everything works lovely.

mouse0270 commented 2 years ago

Sweet, the new locked setting will auto sync that game master setting to users... I probably should remove the sync button from locked settings as the locked setting is already syncing it. I'll make the change before releasing it today.

MrVauxs commented 2 years ago

Yeah was thinking about how relevant that is now.

mouse0270 commented 2 years ago

Syncing a setting is useful if you just want to send your setting to a player, but still lets them change it.

Locked Forces a setting, Syncing just sends it to the player.