search

mouse0270 / module-credits

Lists the authors of projects on the Manage Modules Window. If a url is provided in the module.json file, it will make the version tag link to the module url.
MIT License
7 stars 7 forks source link

Feature Request: Don't mark the topmost changelog shown as viewed implicitly #84

Open esheyw opened 1 year ago

esheyw commented 1 year ago

I'm coming back to my v10 foundry after a couple months of not touching it and just playing on my v9 instance. I wanted to get to a minimum level of UI QoL mods before diving in and reading the changelogs, however on every reload its marking the top listing as viewed when the window opens, even if I just close out of it immediately. I'd prefer if it took an explicit click somewhere to mark viewed.

mouse0270 commented 1 year ago

This is a tough one, because I totally see where you are coming from with this. The problem is this means that when using the module actively though would require an extra click otherwise if you update a few modules you'd have to make additional clicks for them to be marked as read, which I feel might break the flow.

I could compromise and make it so if you have the setting Show New Changelogs On Load set to false, it wont bring up the dialog, but I could add a little notification icon showing you that you have unread changelogs? This would accomplish a similar feeling but would mean that new changelogs would never show up on load and instead you'd have to go to Sidebar > Settings > Changelogs to view them, but would get an indicator that there are unread changelogs.

This will pair nicely with #87 when I add a system to show you the version you last viewed.

esheyw commented 1 year ago

Yea, I'd be fine with having an 'X unread changelogs' badge on the view changelogs button. maybe a marker on the settings tab icon similar to unread chat messages, if that number has gone up (or, if an existing unread has updated again) since last load?