search

moutard / SubZoom-Proto1

1 stars 1 forks source link

Analytics, track users version number #116

Closed rkorach closed 11 years ago

moutard commented 11 years ago

You should close a bug only when it's merge on matser ;)

rkorach commented 11 years ago

?? I never meant to close it, I don't know why I did this!!! (god I'm going crazy :S ) Thanks for watching!

moutard commented 11 years ago

No problem. That's the beginning it's not the first mistake we will make :D

On Thu, Nov 15, 2012 at 11:02 AM, Raphaël Korach notifications@github.comwrote:

?? I never meant to close it, I don't know why I did this!!! (god I'm going crazy :S ) Thanks for watching!

— Reply to this email directly or view it on GitHubhttps://github.com/moutard/SubZoom-Proto1/issues/116#issuecomment-10403154.

rkorach commented 11 years ago

Ok I get it. When you put "fix #issue" in your commit, I think it closes the issue automatically. Right?

moutard commented 11 years ago

Yes i think. Try to respect our convention

"Issue #144 : blabla" because issue are not always bugs to fix sometimes it just features to add etc..

On Thu, Nov 15, 2012 at 11:04 AM, Raphaël Korach notifications@github.comwrote:

Ok I get it. When you put "fix #issue" in your commit, I think it closes the issue automatically. Right?

— Reply to this email directly or view it on GitHubhttps://github.com/moutard/SubZoom-Proto1/issues/116#issuecomment-10403211.