moutard / SubZoom-Proto1

1 stars 1 forks source link

When offline, the start page doesn't load because of Google Analytics #16

Closed fwouts closed 12 years ago

rkorach commented 12 years ago

We need to make a test to see if we are internet connected, and disable analytics if so, or find a way to queue analytics calls until internet is accessed. (I don't know if it is possible, but we'll have to investigate) Two possibilities:

rkorach commented 12 years ago

Other problems with offline are:

It's ok to leave background.html since people may read some pre-loaded articles offline, and we'll be able to gather info.

Chrome offline mode is for apps, not extensions, so I don't think we can use this to detect offline state.

rkorach commented 12 years ago

navigator.onLine seems to work (http://www.toutjavascript.com/reference/reference.php?iref=68)

However, it is strongly argued that it is a mess. http://stackoverflow.com/questions/3181080/how-to-detect-online-offline-event-cross-browser

moutard commented 12 years ago

It seems that with the new class of ga.js there is no error when offline. I don't know exactly why. @HadrienR could you make some tests to check that analytics are really working with a internet connexion. Change bAnalytics to true in config.js and check that data are realy sent. I am not sure I have access to analytics account. Thanks.

HadrienR commented 12 years ago

You do have access (even with your @ct.com) but I can check for you.

Red

On Sunday, August 12, 2012 at 3:44 PM, Raphael Moutard wrote:

It seems that with the new class of ga.js there is no error when offline. I don't know exactly why. @HadrienR (https://github.com/HadrienR) could you make some tests to check that analytics are really working with a internet connexion. Change bAnalytics to true in config.js and check that data are realy sent. I am not sure I have access to analytics account.
Thanks.

— Reply to this email directly or view it on GitHub (https://github.com/moutard/SubZoom-Proto1/issues/16#issuecomment-7675805).

HadrienR commented 12 years ago

I don't think it works. This is what the console tells me when I delete a sticker in "Edit". (see attachment)

Red

On Sunday, August 12, 2012 at 4:13 PM, Hadrien Raffalli wrote:

You do have access (even with your @ct.com (http://ct.com)) but I can check for you.

Red

On Sunday, August 12, 2012 at 3:44 PM, Raphael Moutard wrote:

It seems that with the new class of ga.js there is no error when offline. I don't know exactly why. @HadrienR (https://github.com/HadrienR) could you make some tests to check that analytics are really working with a internet connexion. Change bAnalytics to true in config.js and check that data are realy sent. I am not sure I have access to analytics account.
Thanks.

— Reply to this email directly or view it on GitHub (https://github.com/moutard/SubZoom-Proto1/issues/16#issuecomment-7675805).

HadrienR commented 12 years ago

Ok, it's all good now.