moveit / moveit_calibration

Hand-eye calibration tools for robot arms.
BSD 3-Clause "New" or "Revised" License
143 stars 79 forks source link

Update CI config #83

Closed JStech closed 3 years ago

JStech commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #83 (f8e0547) into master (034f951) will increase coverage by 6.42%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   72.75%   79.16%   +6.42%     
==========================================
  Files          10        9       -1     
  Lines         554      499      -55     
==========================================
- Hits          403      395       -8     
+ Misses        151      104      -47     
Impacted Files Coverage Δ
...t/handeye_calibration_solver/handeye_solver_base.h
...ye_calibration_target/src/handeye_target_aruco.cpp 87.78% <0.00%> (+4.45%) :arrow_up:
..._calibration_target/src/handeye_target_charuco.cpp 88.78% <0.00%> (+5.76%) :arrow_up:
..._calibration_solver/src/handeye_solver_default.cpp 64.62% <0.00%> (+6.89%) :arrow_up:
...t/handeye_calibration_target/handeye_target_base.h 88.08% <0.00%> (+7.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 034f951...f8e0547. Read the comment docs.

JStech commented 3 years ago

I also added a Noetic build. However, this fails. Please have a look!

That test failure is because OpenCV 3.2, the default version for Ubuntu 18.04, has a buggy ArUco board pose detector. See discussion here, #5. I added a check to use the incorrect pose for 3.2 and the correct pose otherwise.