search

moveit / moveit_calibration

Hand-eye calibration tools for robot arms.
BSD 3-Clause "New" or "Revised" License
124 stars 70 forks source link

Convert panel to rviz display #97

Closed JStech closed 2 years ago

JStech commented 3 years ago

Convert the RViz plugin from an rviz::Panel object to an rviz::Display. This allows parameter input and status feedback in the "Displays" panel.

While I was at it, I added parameters for the move_group namespace and PSM topic (borrowed from the PlanningScene display plugin), as well as some status messages for various components.

moveit_cal_display

felixvd commented 3 years ago

I can't review or test right now, but does this remove the panel and tabs? It just adds the entry to the Displays list, right?

JStech commented 3 years ago

I can't review or test right now, but does this remove the panel and tabs? It just adds the entry to the Displays list, right?

The panel and tabs are still there. The only change to the panel GUI was that I removed the camera frustum display parameters from the "Context" tab and made them Display parameters (which you can see in the screenshot). I felt that was a more appropriate place for them.

JStech commented 3 years ago

I just discovered that removing the display crashes RViz. So, not ready to merge yet.

JStech commented 3 years ago

I just discovered that removing the display crashes RViz. So, not ready to merge yet.

Fixed.

mfkenson commented 2 years ago

PR updating the tutorial doc.

https://github.com/ros-planning/moveit_tutorials/pull/705