fix(colors): update to use default colors

mowispace / react-native-logs

Performance-aware simple logger for React-Native and Expo with namespaces, custom levels and custom transports (colored console, file writing, etc.)

MIT License

467 stars 33 forks source link

fix(colors): update to use default colors #96

Open CoryWritesCode opened 7 months ago

CoryWritesCode commented 7 months ago

Adding default colors behaves the way it would seem when initially setting up the project. Let me know if this isn't something you want in here, it just seems like it should have defaults when you see the image initially and then set it up to see no colors out of the box.

fixes #95

CoryWritesCode commented 1 month ago

@alessandro-bottamedi this project still being maintained? See a few PRs need attention.

alessandro-bottamedi commented 1 month ago

Sorry, I’ve been very busy, but I’ll have time to check everything after October 15th! I’ll then release a new version with some of the PRs included…

alessandro-bottamedi commented 1 month ago

Hi, currently the colors are optional, messages are colored only if the colors option in the transport is filled in, also based on custom levels. I would prefer to leave it like this, maybe specifying it better in the readme? It seems cleaner to me to leave the transport options always empty by default... What's your opinion? @CoryWritesCode

CoryWritesCode commented 2 weeks ago

I think thats fine! It just didn't make sense to try what you mentioned in my Issue per the readme. The only issue I would think is that the first image of the lib shows colorization of the logs which made me think that it's available out of the box. So it should probably should be stated better in the readme at least.