mowshon / moviego

MovieGo is a Golang library for video editing.
MIT License
237 stars 16 forks source link

FFmpeg not installed | Request to be able to contribute to the project #7

Closed HGriessel closed 11 months ago

HGriessel commented 12 months ago

Good day,

Thank you for the amazing work done on this project

I had an issue that was obvious after some debugging, and which should have been obviosue to me but I was running on a fresh os and did not think of installing FFmpeg

The error was suppressed/ignored on line 297 only after altering the code to the following did I get this error.

videoProbe, videoProbeError := ffmpeg.Probe(abs)

if videoProbeError != nil {
   log.Printf("Error: %v", err)
   return Video{}, fmt.Errorf("fatal error: %w", err)
}

I also added GetDuration as a method as it was/is useful for me to know the video's duration during runtime.

func (V Video) GetDuration() float64 {
    return V.duration
}

I am fairly new to go and have about 7 years of experience with Python and I am building a small project to cut my teeth on the Golang way of doing things. Would love to be able to contribute to the project as i am also looking for OSS projects to contribute towards.

HGriessel commented 11 months ago

AndreaNicola also has this in the pull request https://github.com/AndreaNicola