search

moxiecode / plupload

Plupload is JavaScript API for building file uploaders. It supports multiple file selection, file filtering, chunked upload, client side image downsizing and when necessary can fallback to alternative runtimes, like Flash and Silverlight.
http://www.plupload.com
GNU Affero General Public License v3.0
5.63k stars 1.42k forks source link

moxie.js function expects 2 arguments, but 3 were provided #1632

Open webbird opened 3 years ago

webbird commented 3 years ago

I have plupload inside a repository which is scanned by a static code analyzer. In line 10216 there is a call to _formatData:

return _formatData(result, op, blob.type);

But the definition in line 10190 is

function _formatData(data, op) {

jayarjo commented 3 years ago

Thanks for heads up! I'm actually surprised that this is the only complaint from it. I however don't have any authority over this project anymore. So don't expect it to be fixed any time soon 😥

You can push a PR here: https://github.com/moxiecode/moxie - hopefully it will get noticed and accepted!

webbird commented 3 years ago

Thanks for the quick reply. Would be easy to fix, but the question is whether 2 or 3 parameters are correct / intended. Apart from the code analysis, it does not seem to have any negative effect.