ruimonteiro93 commented 4 years ago

This is to ensure that all event handlers are properly named, according to the rules specified.

codecov[bot] commented 4 years ago

Codecov Report

Merging #91 into master will not change coverage by %. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines           42        42           
  Branches         1         1           
=========================================
  Hits            42        42

Impacted Files	Coverage Δ
packages/eslint-config-react/lib/rules/react.js	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 235f9b3...a82f985. Read the comment docs.

satazor commented 4 years ago

While not intentional, this is a breaking change correct?

satazor commented 4 years ago

We are missing a test in https://github.com/moxystudio/eslint-config/blob/master/packages/eslint-config-react/test/rules/react.js.

acostalima commented 4 years ago

@ruimonteiro93, what's the status of this? Please follow up.

satazor commented 4 years ago

@acostalima we can’t merge this until https://github.com/moxystudio/eslint-config/pull/91#issuecomment-641452785 is solved.

moxystudio / eslint-config

chore: set checkLocalVariables to true on jsx-handler-names rules #91

Codecov Report