search

mozilla-magnet / magnet-client

A nearby content discovery client for Android & iOS
Mozilla Public License 2.0
19 stars 10 forks source link

Part 1 of #296: Expose preferences to the native side #319

Closed samgiles closed 7 years ago

samgiles commented 7 years ago

Part 1 for #296.

Removes the dependency on AsyncStorage \o/.

I've also tried to make the backend API for Preferences more generic than booleans only.

r? @wilsonpage Android: Also see how there's a mutex lock over the delete and update methods, should prevent weird races. We might want to apply that technique in the subscriptions API too.

r? @arcturus iOS I'm not sure about potential concurrency issues here, do we need a mutex marshalling access through the API for remove and update?

samgiles commented 7 years ago

@wilsonpage How's this?

wilsonpage commented 7 years ago

@samgiles just few comments needed in places. But then ship.ly 👍