mozilla-mobile / android-components

⚠️ This project moved to a new repository. It is now developed and maintained at: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
2.02k stars 473 forks source link

Bug 1796766 - Add support for silent web notifications #12987

Closed Alexandru2909 closed 2 years ago

Alexandru2909 commented 2 years ago

Add support for silent web notifications. The web notifications having the silent flag set will be assigned to a new channel. Since a notification channel's priority can't be changed after it was created, this change will not enable sound on previously allowed notifications after update.

https://user-images.githubusercontent.com/35462038/197219989-13898183-1fc6-4054-bf3d-985eade48bfc.mp4

For the first notification, the default notification sound was played, the second notification was silent.

Pull Request checklist

After merge

GitHub Automation

Used by GitHub Actions.

Alexandru2909 commented 2 years ago

cc @lime124 Based on the discussion here to confirm that making web notifications play the default notification sound is the intended change.

gabrielluong commented 2 years ago

Hey @Alexandru2909, We're just tidying up the PRs since this project moved to a new repository. It is now developed and maintained at: https://github.com/mozilla-mobile/firefox-android