search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

[Bug] custom tab is always light #15371

Closed yajo closed 3 years ago

yajo commented 4 years ago

Steps to reproduce

set night mode. Open a volatile tab from another app.

Expected behavior

Browser bar should be dark.

Actual behavior

It's light: Screenshot_20200923-205143_Firefox

Device information

┆Issue is synchronized with this Jira Task

s-ankur commented 4 years ago

Custom tabs are supposed to be colored by the host app, it should not follow browser theme afiak https://developers.google.com/web/android/custom-tabs/implementation-guide

s-ankur commented 4 years ago

It is not always light either Screenshot_2020-09-28-01-53-24-987_org mozilla fenix

yajo commented 4 years ago

Weird. I'm using feedly, and it shows dark tabs when on dark mode and my browser is the Samsung one:

Screenshot_20200928-154822_Samsung Internet

s-ankur commented 4 years ago

can you specify the host app also?

ekager commented 4 years ago

this might be fixed in a newer version. Let's QA this bug in Nightly and close if we can no longer repro

yajo commented 4 years ago

can you specify the host app also?

Feedly

ebalazs-sv commented 4 years ago

I had tested this on the latest Nightly 200929 05:08 (Build #2015766697) GV 83.0a1 from 9/29 with Motorola Moto G6 (Android 8), Nexus 5 (Android 6.0.1), Samsung Galaxy Tab S3 (Android 8) on several pages and the custom tab is always light, even when the app theme is set to "Dark" or "Follow device theme" and the device is set to Night mode.

Please note that the custom tab main menu, the Share and Tracking Protection pop-ups are all in Dark mode, only the custom tab bar remains light.

20200929_120639

I will remove the qa:needed label for now.

s-ankur commented 4 years ago

Please note that the custom tab main menu, the Share and Tracking Protection pop-ups are all in Dark mode, only the custom tab bar remains light.

Related : #10813

stale[bot] commented 3 years ago

See: https://github.com/mozilla-mobile/fenix/issues/17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

yajo commented 3 years ago

Firefox 92.1.1 (Build #2015832083) AC: 92.0.15, e00bef534d GV: 92.0-20210903235534 AS: 82.1.0

I can confirm this issue still happens when the host app is feedly, but it doesn't happen when it's gmail. Maybe a feedly bug?