search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.25k stars 2.95k forks source link

[regression] Reader View no longer honors Night Mode #15287

Open cpeterso opened 1 year ago

cpeterso commented 1 year ago

Steps to reproduce

  1. Open a news article.
  2. If Night Mode is currently on, turn it off now in Firefox’s hamburger menu.
  3. Activate Reader View.
  4. If Reader isn’t using Light mode, tap the “Light” button to activate it.
  5. Exit Reader View.
  6. Turn on Night Mode in Firefox’s hamburger menu.
  7. Activate Reader View again.

Expected behavior

Reader View should default to Dark mode when Night Move is on.

I think the expected behavior was originally implemented in #4700 back in 2020.

Actual behavior

Reader View defaults to Light Mode, even though Night Mode is on.

Device & build information

I think this bug is a regression starting in Firefox 113. Reader View honors Night Mode in Firefox 112.1 (30078), but not in 113 or later.

┆Issue is synchronized with this Jira Task

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

cpeterso commented 5 months ago

I can still reproduce this bug in Firefox 127.0 (42448).