mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.15k stars 2.91k forks source link

Add "search.default_engine" early in startup to avoid null value #20167

Open data-sync-user opened 4 months ago

data-sync-user commented 4 months ago

┆Issue is synchronized with this Jira Task

data-sync-user commented 4 months ago

➤ Alina Moldovan commented:

Please see below the testing results using FF v1256 (41677) and iPhone 15+ (17.4.1)

  1. No search.defaultEngine mertric is received. we always receive only search.default_engine metric
  2. the following successive events were generated when we run the following steps:

    1. Set the telemetry ON on the device

    2. Received some events like:

      1. "string": { "search.default_engine": "google-b-m" },
    3. Changed the default search engine

    4. Check the glean events:

      1. First event: { "category": "preferences", "extra": { "changed_to": "ddg", "glean_timestamp": "1715247162942", "preference": "defaultSearchEngine" }, "name": "changed", "timestamp": 59859 }
      2. Second event:
      3. "string": { "search.default_engine": "ddg" }

Roux Buciu this seems to be the same behavior as before (used v125 (41705) build for comparation).

Could you please let us know if the testing scenario is correct? if not could you please add some details about what we should test? Also, scould you please change the ticket status to “QA needed“?

CC Norberto Andres Furlan Diana Andreea Barladeanu

data-sync-user commented 4 months ago

➤ Roux Buciu commented:

Heya. yes, it’s search.default_engine in the metrics. It’s search.defaultEngine in the code, which is why I wrote that originally. lol

This testing scenario seems fine. The problem is that we don’t really know where the issue occurs/don’t have steps to reproduce, so, the additional metrics that have been added will probably only trigger on a mass scale wherever the issue is happening.

data-sync-user commented 4 months ago

➤ Alina Moldovan commented:

Marking this issue as verified based on the previous comments