search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.08k stars 2.88k forks source link

Memory exhaustion crash #20764

Open data-sync-user opened 1 week ago

data-sync-user commented 1 week ago

https://mozilla.sentry.io/share/issue/cadb5da088da49e2bf739940b3fa4e56/

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 week ago

➤ Orla Mitchell commented:

Winnie Teichmann This crash was introduced in 127 and looks to be related to the url bar. Do you know if any recent changes might have caused this?

data-sync-user commented 1 week ago

➤ Winnie Teichmann commented:

Orla Mitchell the method adjustURLBarHeightBasedOnLocationViewHeight it is crashing in was added in 127 (PR #20158 ( https://github.com/mozilla-mobile/firefox-ios/pull/20158 )). Could that be the culprit?

data-sync-user commented 3 days ago

➤ Nishant Bhasin commented:

Wanted to remove most of snapkit from the area but since this particular file heavily uses snapkit that would mean re-writing completely so trying out another method from snapkit to help lower and fix the memory issue.

My idea is its better to use the same constraint rather than deactivating and activating it as snapkit should handle it here 🤞

data-sync-user commented 3 days ago

➤ Nishant Bhasin commented:

It would be good to get basic QA around url bar. Note: I didn’t change anything but updated constraints for url bar so worth doing a pass through