[A11y] Requesting Engineering Review - Githubissues

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.24k stars 2.94k forks source link

[A11y] Requesting Engineering Review #21194

Open data-sync-user opened 4 months ago

data-sync-user commented 4 months ago

The microsurvey feature has been completed and hope to ask the a11y team for a review of the feature.

Designs: https://www.figma.com/design/mXN2bu7ma50VkhqCfUpNie/Microsurveys-Mobile?node-id=286-15458

Testing Steps: Navigate to latest nightly and install a fresh build.

Visit the homepage at least twice and the microsurvey should appear. (i.e. open a new tab)

View the microsurvey and verify it meets a11y standards.

┆Issue is synchronized with this Jira Task

data-sync-user commented 4 months ago

➤ ayeddi commented:

Thank you for requesting the review: I’ve filed few microsurvey-related bugs:

LMK if you have any questions!

data-sync-user commented 4 months ago

➤ Cyndi Chin commented:

Thank you for reviewing ayeddi . All the bugs should be addressed and available in the nightly, please let me know if they haven’t. I assigned the tickets back to you!

data-sync-user commented 3 months ago

➤ ayeddi commented:

Hi Cyndi Chin - thank you for your work - all previously reported bugs are now resolved and I have commented on GH issues and closed them.

There is one weird behavior that I seem to miss before (my apologies) is that the focus order for VoiceOver after the Submit button becomes enabled: the Submit and the link are now focused right after the sheet grabber, before the question (refer to the video attached). This would likely prevent blind users of VO from submitting the form, unless they try to do an explore-by-touch but this is not a default behavior

Filed a new bug https://github.com/mozilla-mobile/firefox-ios/issues/21376 ( https://github.com/mozilla-mobile/firefox-ios/issues/21376|smart-link )

data-sync-user commented 3 months ago

➤ Cyndi Chin commented:

Thank you ayeddi ! Please check in the latest nightly and let me know if you still see any issues!

data-sync-user commented 3 months ago

➤ Cyndi Chin commented:

ayeddi Based on our conversation, it seems this ticket can be moved to Done. Wanted to confirm here. Thanks!

data-sync-user commented 3 months ago

➤ Cyndi Chin commented:

ayeddi Moving this ticket to Done based on our conversation here ( https://mozilla.slack.com/archives/C06JLPR4HHC/p1722968232607649?thread_ts=1721750180.105069&cid=C06JLPR4HHC ). The only outstanding a11y ticket will be added the microsurvey follow up epic. Let me know if any issues!

data-sync-user commented 3 months ago

➤ ayeddi commented:

Thank you very much, Cyndi Chin!