search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

[regression] Dragging tabs in the tab tray forgets new tab tray order #22081

Open cpeterso opened 1 month ago

cpeterso commented 1 month ago

Steps to reproduce

  1. Open some tabs.
  2. Open the tab tray.
  3. Long press and drag a tab to reorder your tab tray.
  4. Release the dragged tab.
  5. Wait a couple seconds.
  6. Tap focus to the dragged tab.

Expected behavior

The dragged tab should open the same page as before.

Actual behavior

One of your other tabs’ page will open. If you return to the tab tray, some other tabs may have changed order, too, such as tabs from the bottom row moving to the top.

Sometimes the tab tray order will change before your eyes after waiting a couple seconds in step 5 without needing step 6.

Device & build information

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ Nishant Bhasin commented:

Andrei Bodea // Alina Moldovan could you please check if this is happening on latest main / v131 please

data-sync-user commented 1 month ago

➤ Alina Moldovan commented:

We didn't manage to reproduce this issue at all.

Chris Peterson, could you please add a video to ensure we are following the correct steps? Thank you!

cpeterso commented 4 weeks ago

Here is a recording of the bug. I try to move the Mozilla.org tab in the tab tray, but when I open the tab it is still the original tab (example.com) in the tab tray location. In the video at time 0:10, I tap to open the Mozilla.org tab, but you can see the Mozilla.org tab jumps back to its original location and then the example.org tab opens.

I was NOT able to reproduce in Private Browsing mode, so maybe my profile’s tab metadata is corrupted? I don’t know what else would be different in Private Browsing mode.

https://github.com/user-attachments/assets/a4caebf4-df30-42c2-8e5f-20a0305a81bb

abodea commented 3 weeks ago

I was not able to reproduce it on the latest v9000 (45556) with iPhone 15 Pro (17.5). I also wanted to mention that based on the video it might be something related to the context menu that is displayed right when you long-tap on the tab and then move it, somehow the context menu is closed when the tab is moved but displayed for a few seconds.

badboy commented 2 weeks ago

I noticed the same bug on 45556 yesterday. I'm still able to reproduce it on 45786 today.

https://github.com/user-attachments/assets/f4267136-8f84-4af7-b7a2-dc66daae1e76

cpeterso commented 2 weeks ago

FWIW, I can no longer reproduce this bug. I'm currently using build 9000 (45824), but I reinstalled an older Nightly build and still couldn't reproduce. Maybe something change in my profile or current tab state?

badboy commented 2 weeks ago

Indeed. Can't reproduce on 45824.