search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.15k stars 2.91k forks source link

[Accessibility] Adjust row count for Top Site section on home page depending on font sizes #9826

Open lmarceau opened 2 years ago

lmarceau commented 2 years ago

When bigger font sizes are enabled on the Firefox home page, few characters are readable on the shortcuts section. See screenshot: IMGUNITO-UNDERSCORE!5477!

One solution to this is to adjust the layout of the collection view when a certain text size threshold is reached, so the user can read more of the text (and it's not cutout).

┆Issue is synchronized with this Jira Task

data-sync-user commented 8 months ago

➤ Roux Buciu commented:

Norberto Andres Furlan Daniela Arcese Michael Verdi

Hey ya’ll. A contributor made a PR ( https://github.com/mozilla-mobile/firefox-ios/pull/17952 ) for this, but, as you can see in the screenshot, it changes the number of shortcut items on the screen. Is this behaviour we want, or do we want to keep them as the original number of shortcuts (whether the default or the number the user set)?

data-sync-user commented 8 months ago

➤ Michael Verdi commented:

I’m not sure if this is exactly what we want. Ekaterina Galetski has been working on some updates to top sites. I’ll confer with her and see how this fits in with what she was already thinking about.

data-sync-user commented 8 months ago

➤ Ekaterina Galetski commented:

Who is the dev assigned to this project?

data-sync-user commented 8 months ago

➤ Roux Buciu commented:

Ekaterina Galetski, as I said in my message, this is a contributor, so, no dev. I got picked to review it randomly, so I’m driving the conversation. 🙂

data-sync-user commented 8 months ago

➤ Ekaterina Galetski commented:

We want to revisit this accessibility design work at some point. I recommend we should probably mark that ticket as not to be done by contributors because it needs UX.