search

mozilla-mobile / focus-android

⚠️ Firefox Focus (Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
2.11k stars 711 forks source link

URL Autocomplete - The "back" action does not redirect the user correctly #4395

Closed Diana-Rus closed 1 year ago

Diana-Rus commented 5 years ago

Steps to reproduce

  1. Open Firefox Focus and navigate to "Settings"/"Search"/"URL Autocomplete".
  2. Tap on the "Learn More" SUMO link.
  3. Tap on the "Back" of the device.

    Expected behavior

    The user is sent back to "URL Autocomplete" section.

    Actual behavior

    The user is sent to the first page.

    Device information

Note: It should be the same implementation as for "i" icon for "Add search engine" option.

ghost commented 4 years ago

Hi @Diana-Rus , I want to work on this issue. Can you please help?

arvinth10 commented 4 years ago

Could I take this issue?

delia-pop commented 3 years ago

This issue was reproduced again on RC 92.1.0 (Build 352442046 ; 92.0-20210901142158) with Huawei P9 Lite (Android 8). The user is still redirected to the main page after tapping the back button from the "Learn more" links, instead of being sent back to "URL Autocomplete" section.

lobontiumira commented 2 years ago

Reproducible on the latest Focus Nightly 99.0 build from 2/23 with Google Pixel (Android 10).

ionutbedregeanu commented 2 years ago

@amedyne @jeffreygee I made a pr for this following the same approach as here, but I'm not sure that's what we want. In Fenix the current behaviour, to open a normal tab and go back to home screen is considered expected, so maybe should keep the same flow in Focus. What do you think?

jeffreygee commented 2 years ago

@ionutbedregeanu - IMO, the proper UX should be that the back button should follow the breadcrumb and return to the last spot. I did notice we don't follow this on Firefox. Let me take this back to the team and see if there's a reasoning for this.

cpeterso commented 1 year ago

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1802253

Change performed by the Move to Bugzilla add-on.