mozilla-services / python-dockerflow

A Python package to implement tools and helpers for Mozilla Dockerflow
https://python-dockerflow.readthedocs.io
Mozilla Public License 2.0
38 stars 21 forks source link

Update Django docs #109

Closed jwhitlock closed 4 months ago

jwhitlock commented 4 months ago

This refreshes the Django docs, and adds some information that may be useful.

jwhitlock commented 4 months ago

I decided to use dockerflow instead of dockerflow.checks.register in the sample logging config. This should have the same effect, but allow moving files around or catching logs from other locations. I also fixed the name of RequestIdLogFilter in the example.

leplatrem commented 4 months ago

Thanks @jwhitlock for the contribution 👏

We will have to postpone the review for a few days 🙏

jwhitlock commented 4 months ago

Thanks @leplatrem, I've applied the changes, including RequestIdLogFilter across the project. I've been focused on the Django docs, I see others are better about updating all the docs.

traceparent does look interesting to me. I'd want to see how GCP implements it before making it the default, and maybe talk to the SREs about how we'd integrate it.

leplatrem commented 4 months ago

Thank you!