search

mozilla-services / python-dockerflow

A Python package to implement tools and helpers for Mozilla Dockerflow
https://python-dockerflow.readthedocs.io
Mozilla Public License 2.0
38 stars 21 forks source link

Add querystring to MozLog `"request.summary"` #97

Closed leplatrem closed 6 months ago

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.01%. Comparing base (2ba0254) to head (a6e6481).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #97 +/- ## ========================================== + Coverage 97.97% 98.01% +0.03% ========================================== Files 22 22 Lines 692 705 +13 Branches 92 96 +4 ========================================== + Hits 678 691 +13 Misses 8 8 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexcottner commented 6 months ago

I am assuming we won't have anything sensitive in the query string.

leplatrem commented 6 months ago

I am assuming we won't have anything sensitive in the query string.

Now that you say it, maybe it should be behind a setting and opt-in, just to be extra safe.