search

mozilla / Snappy-Symbolication-Server

https://wiki.mozilla.org/Snappy_Symbolication_Server
Mozilla Public License 2.0
3 stars 12 forks source link

Add support for Travis CI (Issue #32) #42

Closed bytesized closed 8 years ago

bytesized commented 8 years ago

This Pull Request adds support for Travis CI to the repository as per Issue #32. When I pushed the latest commit to my repository, it passed in Travis, so I believe it should all be ready to go.

@willkg Can you review this? Most of the changes were to fix the linter. There are very few actual code changes.

willkg commented 8 years ago

Mmm... Github shows stuff like this poorly. I'll have to pull it local and figure out how to diff the before and after effectively. I'm pretty sure I've done that before, but I forget how I did it.

I'll try to do that this week.

willkg commented 8 years ago

I pulled this branch down and then did a:

git diff master..HEAD -w --patience

That shows a diff of just the code changes. I went through those--they're predominantly cosmetic.

I'm not able to run the tests again. I could try to resurrect my docker changes on top of the new docker setup, but that's time I don't have to spend on this project.

As far as I can tell, this looks ok to me.