mozilla / addon-recommendation-shield-study

Stand-alone verison of Add-on Recommendation for Shield Study
Mozilla Public License 2.0
3 stars 7 forks source link

Remove all recommendations which open tabs with sketchy malware ads #24

Closed casebenton closed 8 years ago

casebenton commented 8 years ago

This constraint removes a lot of the recommendations. There are only 7 left if we remove all of these, so we should probably find some new ones. None of the 7 remaining add-ons open new tabs on install.

r?

Osmose commented 8 years ago

That many? Man...

@MattGrimes What do you think? Is it worth avoiding the sketchy ads to get rid of all these add-ons?

mythmon commented 8 years ago

Is the restriction on addons that open tabs on install? Or addons that open tabs on install that have sketchy things?

casebenton commented 8 years ago

As I understand it, the issue is that the tabs that are opened on install have sketchy ads. All of the add-ons that I removed have this issue, and that also happens to be all of the add-ons that open tabs.

gregglind commented 8 years ago

(I personally only care if the opened tab is itself sketchy. Luckily there is no difference.

R+ (F+) and I would bring this continuing grossness to AMO team pm)

MattGrimes commented 8 years ago

I agree with Gregg here. It's more about the content of the new tab than the action itself. Still seems to be a moot point though.