search

mozilla / addon-recommendation-shield-study

Stand-alone verison of Add-on Recommendation for Shield Study
Mozilla Public License 2.0
3 stars 7 forks source link

Fix issue where uninstall and reinstall of addon breaks panel show #31

Closed casebenton closed 8 years ago

casebenton commented 8 years ago

Issue isn't yet fixed for the window that handles the uninstall. Seems to work now for windows other than the window that initiated the uninstall.

casebenton commented 8 years ago

@Osmose here's what I've done so far if you're curious

Osmose commented 8 years ago

Code looks fine, nice work!

The commit messages could use a bit of work. The first commit doesn't actually fix the bug so you should remove the fix message from it. You also don't need to mention that the issue still isn't fixed in the commit messages, and the third commit should have the extended description in a paragraph below the subject line, rather than all on one line:

Short summary of what the commit does.

Larger description of the commit! Woo!

Otherwise, I'm r+wc on this, nice fix!