mozilla / addon-recommendation-shield-study

Stand-alone verison of Add-on Recommendation for Shield Study
Mozilla Public License 2.0
3 stars 7 forks source link

Apply "box-sizing: border-box" to all elements #35

Closed casebenton closed 8 years ago

casebenton commented 8 years ago

This is something that I should have done from the beginning. I thought that the effects of this rule were already in place by default, so I was confused several times when margins did not behave in a way that I expected. I didn't think that this was why though.

Most notably, when I brought in _installButton.scss originally, the install button did not look as expected because the writers had assumed that border-box was applied somewhere else. I made some adjustments to it a while ago, not knowing that I should have used border box. I've now brought the original verison of _installButton from the disco page back in.

There were several css adjustments I had to make the switch to border-box.

@mythmon r?