mozilla / addon-recommendation-shield-study

Stand-alone verison of Add-on Recommendation for Shield Study
Mozilla Public License 2.0
3 stars 7 forks source link

if observe-only doesn't do any ui ever, don't open the example tab. #45

Closed gregglind closed 8 years ago

gregglind commented 8 years ago

(Confirm that existing code works like this)

casebenton commented 8 years ago

This won't happen, as the observe-only branch never creates a Recommender instance and calls Rec.start(). Onboarding event, which opens example tab, is called in Rec.start() method.

const variations = {
  'passive-panel'() {
    Rec = new Recommender();
    Rec.start();
  },
  'auto-open-panel'() {
    simplePrefs.prefs.autoOpenPanel = true;
    Rec = new Recommender();
    Rec.start();
  },
  'observe-only'() {},
};