mozilla / addon-recommendation-shield-study

Stand-alone verison of Add-on Recommendation for Shield Study
Mozilla Public License 2.0
3 stars 7 forks source link

Specify addon is multiprocess compatible #82

Closed casebenton closed 8 years ago

casebenton commented 8 years ago

@mythmon r?

mythmon commented 8 years ago

Is this because the addon doesn't work at all on multiprocess? Or is this because multiprocess users will all be without addons right now, so we don't want to recommend them addons?

casebenton commented 8 years ago

This addon won't work with multiprocess because it uses low level SDK APIs. The automatic validator on AMO is mad at me for not specifying this.

casebenton commented 8 years ago

Screenshot from the addon listing on AMO

screen shot 2016-08-17 at 8 40 03 am

This will change "unknown" to something like "not compatible"

mythmon commented 8 years ago

Low level SDK APIs can be multiprocess safe. I'm not sure the addon is multiprocess compatible, but I'm pretty sure it is. Given the recent push to get multiprocess out on release, I think marking this addon as incompatible will drastically reduce our population. Can we work around this?

mythmon commented 8 years ago

r+