search

mozilla / addons-linter

🔍 Firefox Add-ons linter, written in JavaScript. 👁
Mozilla Public License 2.0
319 stars 144 forks source link

Trim `relaxed-json` dependencies #5420

Closed fregante closed 2 months ago

fregante commented 3 months ago

As mentioned in https://github.com/mozilla/addons-linter/issues/3910#issuecomment-2308814995, relaxed-json has duplicate key detection so it cannot easily be replaced.

And we don't have to. The only problem with the package is that it has a lot of CLI dependencies.

Since the package has been stable/undeveloped for 5 years, I just forked it to publish an API-only version, documenting it: https://github.com/fregante/relaxed-json#readme. This was brought up to its developer 3 years ago already but no response.

This drops all of its deps:

Screenshot 1
willdurand commented 2 months ago

@fregante can you rebase please?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.77%. Comparing base (924db3f) to head (2f3881e). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5420 +/- ## ======================================= Coverage 98.77% 98.77% ======================================= Files 51 51 Lines 2855 2855 Branches 867 867 ======================================= Hits 2820 2820 Misses 35 35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.