search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Sometimes a saved star rating disappears #10136

Closed kumar303 closed 6 years ago

kumar303 commented 7 years ago

Describe the problem and steps to reproduce it:

What happened?

Sometimes the star rating you just entered does not appear. It may look like you had not actually rated the add-on.

What did you expect to happen?

The saved star rating should always appear.

Anything else we should know?

This is blocked on https://github.com/mozilla/addons/issues/3752

As a workaround, what we do is request all user reviews and filter by add-on and version to find the one that matches. However, the current code does not use paging to find all results which is why the rating sometimes "disappears."

kumar303 commented 7 years ago

Fixed in https://github.com/mozilla/addons/issues/10145

kumar303 commented 7 years ago

for QA: this was pretty hard to reproduce to begin with (the add-on had to have had enough ratings to exceed the page size)

ValentinaPC commented 7 years ago

I am still able to reproduce this on AMO-dev FF52(Android 6.0.1), intermittently. Used add-on: https://addons-dev.allizom.org/en-US/android/addon/facebook-phishing-protector/?src=search Video for this issue: videotogif_2017 03 22_13 56 07

kumar303 commented 7 years ago

This is probably the same as https://github.com/mozilla/addons/issues/10228 but I don't know if it's related to the original patch for mozilla/addons-server#1812 or not yet.

ValentinaPC commented 7 years ago

This is probably the same as mozilla/addons#2717 but I don't know if it's related to the original patch for mozilla/addons-server#1812 or not yet.

In mozilla/addons#2717 A review is dismissed, here, the review is made...until ...the end :)

kumar303 commented 7 years ago

In mozilla/addons#2717 A review is dismissed

Dismissing the text review doesn't matter because at that point the initial star rating selection has already been saved. You can submit the text review, cancel the text review, dismiss the text review, whatever -- when you refresh the page, the same thing happens. The root cause is that the API response to show the saved star rating is cached too aggressively (https://github.com/mozilla/addons/issues/4180).

I'll leave both bugs open so we can verify all use cases when it's fixed.

muffinresearch commented 6 years ago

@vcarciu is this still an issue?

vcarciu commented 6 years ago

@muffinresearch : no, the issue is not reproducible anymore. We can close it.