"More Popular" Themes/Extensions are not sorted correctly

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨

Other

125 stars 41 forks source link

"More Popular" Themes/Extensions are not sorted correctly #10187

Closed ValentinaPC closed 6 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

Load AMO-dev on you device : https://addons-dev.allizom.org/en-US/android/
Go to "Browse All Themes"
Tap on "More Popular Themes"

Expected results: Themes sorted ascending by users are displayed.

Actual results: Random themes are listed.

Notes/Issues:

"Most Popular Themes" section is also not sorted after popularity
"Most Users" option from Sort menu is not selected, as "Top Rated" is selected wile accessing "More Highly Rated Themes".
shouldn't we use same terms for popular themes? ("More Popular Themes" in themes homepage vs. "Most Users" option from Sort menu) Verified on AMO-dev FF51(Android 6.0.1). Video for this issue:

ValentinaPC commented 7 years ago

While using the new desktop pages, and accessing the page indicated in this issue - https://addons-dev.allizom.org/en-GB/firefox/search/?sort=hotness&type=extension - we will see no sort option being selected....I guess is not intended. See screenshot: sort_001

ValentinaPC commented 7 years ago

This is happening for the new Filter menu also. more popular

tofumatt commented 7 years ago

It seems we lack a "popularity" feature in the sort options which maps to "hotness" on the API.

We should add that sort option and this shoud be fixed, I'd think.

willdurand commented 6 years ago

@tofumatt does that mean our SEARCH_SORT_POPULAR constant is flawed? https://github.com/mozilla/addons-frontend/blob/10146082fb9b11b21408dd80ef14a6f5b24214f6/src/core/constants.js#L100

Related bug report: https://github.com/mozilla/addons/issues/10845

ValentinaPC commented 6 years ago

This is happening for each category.

tofumatt commented 6 years ago

Hmm, I guess this is a semantic difference then. "Popular" doesn't mean "by users", it means "what's popular"–the API lists it as "(average number of users progression), descending."

Maybe we need another option for "User count". @pwalm–what do you think about this? The idea with the popular sort is it's sort of ephemeral/changing with new add-ons getting more downloads, etc. But if that's confusing and people think it means "by most users" we should drop it/change it.

pwalm commented 6 years ago

How about "Trending"? That indicates add-ons that are popular right now.

tofumatt commented 6 years ago

Works for me!

So we’ll change “popular” to “trending” and add a new “popular” that maps to “most users”. Yay!

willdurand commented 6 years ago

@tofumatt could you please explain what should be changed because I am a bit confused currently.

Do we have to replace all strings "Popular" by "Trending"?
Do we have to change the sort algorithm in mozilla/addons#10845 (most popular add-ons on homepage)?
Where do we want "most popular" as in "trending" instead of "most users"?

tofumatt commented 6 years ago

Ah, this was assigned to me so I was gonna grab it, but:

Yes, the existing strings for "popular" should be changed to "trending". The constant should be changed too; anything pointing to the actual string 'hotness' should be called TRENDING.
Most popular on the homepage should be changed to be most users, yes.
We want trending as a search filter, not sure if it exists on the homepage.

@devaneymoz: Did you want "Popular" on the homepage to mean "trending/up and coming" or "Most users"?

willdurand commented 6 years ago

There should also be a up and coming shelf (the last one).

ValentinaPC commented 6 years ago

Verified as fixed on AMO-dev FF56(Win 7). Popular add-ons are correctly sorted. A new sort option was added - trending - for the up & coming extensions. Postfix screenshots: more popular-homepage ext_homepage