mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

"No results were found" for some categories while being in "View Mobile Site" #10199

Closed ValentinaPC closed 7 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

  1. Load https://addons-dev.allizom.org/en-US/firefox/ desktop (device)
  2. Click "View mobile site"
  3. Go to "Block ads" category

Expected results: Add-ons from that category are listed.

Actual results: "No results were found" message is displayed.

Notes/Issues:

Verified on AMO-dev FF51(Win 7, Android 6.0.1) Video fro this issue: videotogif_2017 03 06_15 29 51

muffinresearch commented 7 years ago

This will be resolved as the mobile site is expanded onto desktop. Currently the categorization is different for android and firefox although I wonder if that should continue to be the case as we update the mobile site to work with desktop too?

ValentinaPC commented 7 years ago

Reproducing also for FF 6.1(1) under iOS 9.3.5. Screenshot: iphone

ValentinaPC commented 7 years ago

This is also happening in the new desktop pages because the category from desktop is "Privacy & Security" while on "View Mobile Site" we call "https://addons.allizom.org/en-US/firefox/extensions/security-privacy/". Screenshot: 2017-06-21_1827

ValentinaPC commented 7 years ago

This is in -prod.

tofumatt commented 7 years ago

Just for the record this is because those categories don't exist for desktop Firefox.

It might actually be best to 404 when the category isn't found.

ValentinaPC commented 7 years ago

Just for the record this is because those categories don't exist for desktop Firefox.

The interesting fact is that for the first category "Block Ads" we load the page https://addons-dev.allizom.org/en-US/android/extensions/security-privacy/ and for desktop we have https://addons-dev.allizom.org/en-US/firefox/extensions/privacy-security/ :)

tofumatt commented 7 years ago

Yes, that’s because we have different categories for desktop versus mobile :-/

ValentinaPC commented 7 years ago

Based on https://github.com/mozilla/addons/issues/10268 this can be closed.