search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Post-install notification popup is superfluous #10245

Closed muffinresearch closed 6 years ago

muffinresearch commented 7 years ago

Describe the problem and steps to reproduce it:

Need to check this on release once in prod, but in FF Android nightly it looks like the post-install notification is superfluous since there's a notification that pops-up from the bottom of the screen which is shortly followed by a notification at the top of the screen.

Assuming this is also the case in release let's conditionally remove the post-install notification for FF Android.

img_1082

pwalm commented 7 years ago

We just spoke with Jack in Taipei about this, he has experienced the same issue. Let's kill the top notification.

ValentinaPC commented 7 years ago

I receive now, two notifications on AMO-prod FF53(Android 6.0.1) for require restart add-ons at install and no notification at uninstall. Please see screenshot and video: restart videotogif_2017 05 12_12 28 45

@muffinresearch : should I log a separate issue for the uninstall part?

muffinresearch commented 7 years ago

@ValentinaPC since we're moving in the direction of the browser controlling notifications this would need a bug filing on bugzilla.

ValentinaPC commented 7 years ago

Done: https://bugzilla.mozilla.org/show_bug.cgi?id=1364405 Thanks!

muffinresearch commented 6 years ago

I think this is no longer an issue.

ioanarusiczki commented 6 years ago

Verified on AMO dev with FF58 (Android 8.0.0)