search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Dismissed review on mobile playing hide&seek on desktop #10372

Closed ValentinaPC closed 7 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

  1. Find an unreviewed add-on on your Android device
  2. Select some rating stars, but dismiss the review popup (by clicking outside the popup)
  3. Go to desktop and find that add-on i.e. https://addons.allizom.org/en-US/android/addon/testrelease05-010-17-1-0/?src=ss

Expected results: The add-on has the same number of reviews in the header section of add-on details page as in the "Reviews" section.

Actual results: The add-on has 1 user review as a link and "This add-on has not yet been reviewed. Be the first!" in the Reviews section below.

Notes/Issues:

Verified on FF53(Android 6.0.1, Win 7). Issue is reproducing on both stage and dev. Screenshot and video for this issue: videotogif_2017 05 11_18 04 48 duck

kumar303 commented 7 years ago

This is probably due to caching. Can you try it again but wait 10 minutes before checking it on desktop?

ValentinaPC commented 7 years ago

Tried after a day - same results - I don't think is cache. Add-on: https://addons.allizom.org/en-US/firefox/addon/duckduckbang/?src=ss Screenshot: 2017-05-12_0930

muffinresearch commented 7 years ago

@ValentinaPC Isn't this expected behaviour now, since doesn't the addons-server site filters reviews with no comment as per https://github.com/mozilla/addons-server/pull/5227 - or were you logged in as the same user in both cases?

In any case the contradictorary messaging seems odd.

ValentinaPC commented 7 years ago

@muffinresearch: The behavior is to hide the empty reviews, yes, but here I am talking about a dismissed review (with no action on the "submit review" button) and I am also, signed out. 2017-05-12_1633

muffinresearch commented 7 years ago

Afaik ratings on the mobile site are submitted even if you don't write text. That was how the UX was defined so that writing text was not a requirement.

I think the filtering out of non-body reviews is not complete and that should be filed for on addons-server.

ValentinaPC commented 7 years ago

Afaik ratings on the mobile site are submitted even if you don't write text

Even if I don't click "submit review" but outside the popup?

muffinresearch commented 7 years ago

Even if I don't click "submit review" but outside the popup?

@ValentinaPC yep. See https://github.com/mozilla/addons/issues/10136

muffinresearch commented 7 years ago

@ValentinaPC I'm not sure what to do with this bug, I don't think there's anything to do in this repo - but you might want to file for the inconsistent messaging and filtering for the current frontend on addons-server.

ValentinaPC commented 7 years ago

I've logged this under add-ons server repo. (https://github.com/mozilla/addons/issues/4441) Closing thins.