Tapping on any category loads a 404 page for a few seconds

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨

Other

125 stars 41 forks source link

Tapping on any category loads a 404 page for a few seconds #10621

Closed ValentinaPC closed 7 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

Load AMO homepage on you device https://addons-dev.allizom.org/en-US/android/
Tap on a category i.e. "Blocks ads"

Expected results: Category is loaded without any display or layout issues.

Actual results: A 404 page is loaded for a few seconds.

Notes/Issues:

happening first time the page is loaded - reproduce is you must load the page again in a new tab;
reproducing on new desktop pages also;
may be a regression from mozilla/addons#10268

Verified on FF54(Win 7). Issue is reproducing around all AMO servers. Video for this issue: videotogif_2017 07 24_11 04 39

tofumatt commented 7 years ago

Shoot, I thought the code handled the loading state appropriately but seemingly not. I'll get this, should be able to fix it before the tag tomorrow as it's kind of janky UX.

tofumatt commented 7 years ago

Hah, this is because the categories and the search load separately, and we have an issue with the categories not being loaded (and category being false during the check, here) while the search is (and thus saying loading is false.

Looks like loading needs to be set based on multiple loading states or this needs to be a bit more robust. Should be an easy fix, just weird to track down.

ValentinaPC commented 7 years ago

Verified as fixed on AMO-dev FF54(Win 7, Android 7.2.1). A 404 page is not longer displayed while accessing any categories from homepage. Postfix video: cat