mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

[Task]: Make up is, like, better #15066

Open KevinMind opened 1 month ago

KevinMind commented 1 month ago

Description

This Ticket encapsulates a potential solution to the issues documented in these tickets:

The solution entails:

Down sides of this approach are mostly in the last point. We are essentially moving logic out of the docker build and into makeup, which could be faster, but is more complicated and means we need to be aware of the stage we are running to know what to do.

Acceptance Criteria

### Milestones/checkpoints
- [ ] make up brings all containers up and running stably and consistently
- [ ] make up takes less than one minute consistently
- [ ] make up can run in CI with minimal work
- [ ] switching between branches does not significantly impact make up time
- [ ] https://github.com/mozilla/addons/issues/15190
- [ ] https://github.com/mozilla/addons/issues/15191

Checks

┆Issue is synchronized with this Jira Task

KevinMind commented 1 month ago

I'm not necessarily suggesting that we implement exactly what is in this issue in this issue. We can move towards a target in incremental steps. But I think at this point it is worth discussing with the team the tradeoffs and what we value more.