[Bug]: emails sent from Cinder to reporters or authors don't have the appeal urls included

[ioanarusiczki]

What happened?

I am filling a followup for the comment made here https://github.com/mozilla/addons/issues/15068#issuecomment-2435498101

Emails sent to reporters or authors no longer have the appeal urls attached.

Example of email sent to reporter (with Approve)

Example of email sent to author when content is disabled

What did you expect to happen?

Not sure it's what's going on but this is not reproducible on stage righ now.

Is there an existing issue for this?

• [X] I have searched the existing issues

┆Issue is synchronized with this Jira Task

[eviljeff]

Confirming. It's a tricky regression from https://github.com/mozilla/addons/issues/15074 - we don't set CinderDecision.action_date until after the emails have been sent (thinking: we'd want it only to be set when everything completed successfully); but CinderDecision.can_be_appealed is called when generating the email, and relies on action_date being set.

[ioanarusiczki]

I think this is fixed. I checked with an extension, a user, I've emails with appeal urls attached

email sent to a reporter

email sent to an author