search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Don't preview a theme if the user wants to scroll #9988

Closed mstriemer closed 7 years ago

mstriemer commented 7 years ago

Describe the problem and steps to reproduce it:

Tap the theme header image and try to scroll. The theme is previewed, scrolling does not happen.

What happened?

The theme header touch events have prevented default so that the user isn't shown a context menu when long pressing but this cancels scrolling too.

What did you expect to happen?

If I scroll quickly I should get scrolling. If I keep my finger within the theme header image for a few hundred ms I should get a preview.

Anything else we should know?

theme-preview-finalish mp4

Extracted from mozilla/addons#9980 and mozilla/addons-frontend#1442.

mstriemer commented 7 years ago

@pwalm is it okay if we reduce the touch target to just the button on the image?

We have a fix in mind for this issue but it's a bit of a hack and aren't 100% sure it will work.

ValentinaPC commented 7 years ago

Verified as fixed on AMO-dev FF51(Android 6.0.1) videotogif_2017 02 06_17 54 19