search

mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
241 stars 98 forks source link

improve logging for bigquery-etl circleCI dry_run_sql #4161

Open data-sync-user opened 11 months ago

data-sync-user commented 11 months ago

currently failures are logged by timestamp and a failure might be hidden in between lots and lots of output

to make it easier to see what the problem was it would be nice to collect all errors and print them at the end for better readability

https://app.circleci.com/pipelines/github/mozilla/bigquery-etl/23638/workflows/b67d3464-56c8-4e3c-b530-59d8bd6c9840/jobs/242023 example for failed dry_run_sql

┆Issue is synchronized with this Jira Task

data-sync-user commented 3 weeks ago

➤ Ben Wu commented:

This is partially implemented with https://github.com/mozilla/bigquery-etl/pull/5771 ( https://github.com/mozilla/bigquery-etl/pull/5771|smart-link )

The list of queries is printed at the end (example ( https://app.circleci.com/pipelines/github/mozilla/bigquery-etl/35759/workflows/bcbf30f2-9039-47b7-844a-9da99bc71182/jobs/401538 )) so it’s easier to search for things. There’s still room for improvement by adding the error messages as well but that will likely take some reorganizing of the code