search

mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
179 stars 80 forks source link

Fix #66: Add onReady to django_browserid.registerWatchHandlers. #263

Closed Osmose closed 10 years ago

Osmose commented 10 years ago

@peterbe r?

willkg commented 10 years ago

This looks ok to me. My one curiosity is that onReady in the persona docs suggests it is invoked when the user agent is ready to process calls for id.request and id.onLogout. We don't use the latter anymore. Is id.request a part of the onLogin cycle?

Osmose commented 10 years ago

Is id.request a part of the onLogin cycle?

Yep, django_browserid.getAssertion calls it.

willkg commented 10 years ago

I'm going to usurp @peterbe here and and give an r+.

@peterbe feel free to be like, "dude--this is the worst stuff ever. i override you with the power of Greyskull. r-------!"